Fix indicator not opening when the translucent style is active#685
Open
leolost2605 wants to merge 1 commit intomainfrom
Open
Fix indicator not opening when the translucent style is active#685leolost2605 wants to merge 1 commit intomainfrom
leolost2605 wants to merge 1 commit intomainfrom
Conversation
Member
|
This margin is here because of the box shadow. Without it, the box shadow gets clipped. I think now we can maybe use 'overflow = VISIBLE`? But I was looking at this the other day and the dock does some other stuff to make sure struts are set correctly while not clipping shadows |
leolost2605
force-pushed
the
leolost/fix-indicator-not-opening
branch
from
4d16de9 to
42ae04c
Compare
Member
Author
|
Ahh ok I added some manual size calculation to make sure we include size for the box shadow without it messing with something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently indicator can't be opened when the panel is in the translucent style. This fixes that.
I don't really know why this breaks it but I also don't seem to see any difference without this so I decided to just remove it.