Closed
Conversation
leolost2605
reviewed
Mar 24, 2026
Member
leolost2605
left a comment
There was a problem hiding this comment.
IMO we shouldn't convert to a Singleton. There's a bunch of literature that Singletons are considered an anti pattern except for a few very specific cases (e.g. a log).
https://en.wikipedia.org/wiki/Singleton_pattern#Criticism
In my experience in a few personal projects, not using singletons leads to a better structure because you have to think about who uses what. Also IMO the code it saves here isn't really code that we have to try to reduce, since it's not really any logic. But that's just my opinion based on what I found and heard from others 🤷
Member
Author
|
That's a fair criticism and maybe this can be cleaned up in a better way. I'll approach it with a different mindset. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make popovermanager a singleton instead of passing around references to it