Open
Conversation
leolost2605
force-pushed
the
leolost/maximize-gesture
branch
from
025290b to
cf784bf
Compare
leolost2605
changed the title
leolost2605
force-pushed
the
leolost/maximize-gesture
branch
from
cf784bf to
3aef6a4
Compare
garaevdi
reviewed
Mar 20, 2026
leolost2605
force-pushed
the
leolost/maximize-gesture
branch
from
3aef6a4 to
8ab3b34
Compare
Contributor
|
Tested it once more, but still it's kinda broken. Could Kooha-2026-04-02-12-04-05.mp4 |
garaevdi
reviewed
Apr 4, 2026
| } | ||
|
|
||
| public override void commit_progress (GestureAction action, double commit) requires (action == TOGGLE_MAXIMIZED) { | ||
| if (current_window == null) { |
Contributor
There was a problem hiding this comment.
This check should be something like: if (current_window == null || current_window.get_window_type () != Meta.WindowType.NORMAL || !current_window.can_maximize ()) so this wouldn't happen
Kooha-2026-04-04-14-55-30.mp4
If we managed to register our captured event handler before another instance it can happen that we steal the gesture from the other instance. E.g. the user clearly swipes horizontal but once they swiped long enough they drifted over the vertical threshold and we will start stealing the gesture.
leolost2605
force-pushed
the
leolost/maximize-gesture
branch
from
41a1fb3 to
bc38426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1697
On my system touchegg had a gesture configured for four finger swipe down which would mess with this gesture but idk if that's just on my system. If the gesture is configured for you too just kill touchegg and you can test this.
To test make sure you enable it via dconf editor and not via the settings because that would also enable the touchegg gesture which also messes with this.
I'm not sure how the old gesture worked but I decided to go for swipe up -> maximize, swipe down -> unmaximize.
It will animate a tile from the window position to maximized and from maximized to the old window position. I'd be happy about some UX input here whether it's ok like it's currently or what could be improved :)
Kooha-2026-03-02-21-50-17.mp4