Fix Wingpanel dialogs dock and workspace behavior

[lenemter]

Fixes elementary/wingpanel#645

[leolost2605]

Wouldn't get_window_is_normal (window) && !ShellClientsManager.get_default ().is_positioned_window (window) also work? That would also prevent things like the polkit dialog to show up.

[lenemter]

@leolost2605 That would prevent onboarding showing up in the dock (which should not on top but that's another issue). I don't have a strong opinion here and both solutions are fine for me

[leolost2605]

@lenemter that was fixed in #2709

[lenemter]

@leolost2605 TBH the reason why I implemented this way is not to rely on ShellClientsManager. I want to use window properties as much as possible instead of relying on pantheon shell protocol

[leolost2605]

Any particular reason for that? Pantheon shell protocol and therefore the ShellClientsManager is now with wayland the only authority about what windows are shell windows so IMO it makes sense to only use that instead of a hint set by it which is kind of an implementation detail. Also in the future mutter wants to move away from window types so I think it makes sense we already go with our thing.
Also like I said this would also prevent things like the polkit dialog or end session dialog to show up which makes sense to me.