Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
dsanders11
left a comment
There was a problem hiding this comment.
Discussed on Slack refactoring this to avoid a double build situation for the release workflow.
build.yml workflow|
Added a universal build as well here! |
dsanders11
left a comment
There was a problem hiding this comment.
Two things:
- Is there much benefit to adding a universal macOS build this late in the game? Not sure it's worth introducing, TBH
- Not sure we want to upload the artifacts for these builds. The artifacts will total several gigabyte for each run given all the variants, that's going to eat a lot of space quickly.
@dsanders11 this stems from a previous Slack discussion we had about the Fiddle download page. Browser support for architecture detection is spotty and intrusive for users, so providing a single universal target is the easiest way of shipping the correct architecture for all users. Looking at the download stats, we're still on 2/3 arm64 vs 1/3 x64 downloads for macOS.
Good point. Looks like the free GHA limits are relatively low: https://docs.github.com/en/billing/concepts/product-billing/github-actions#free-use-of-github-actions |
|
Had a brief discussion with @dsanders11. Going to add Universal in a follow-up if we choose to add the target. |
Adds
yarn maketo our test + post-merge flows.Did a bit of cleanup for our workflows in general:
.nvmrcwith the version we use for releasing/testing.@types/nodeto latest 22.Note that these artifacts are unsigned.