Skip to content

ci: add builds to test workflows#1815

Merged
erickzhao merged 12 commits intomainfrom
build-workflow
Nov 19, 2025
Merged

ci: add builds to test workflows#1815
erickzhao merged 12 commits intomainfrom
build-workflow

Conversation

@erickzhao
Copy link
Member

@erickzhao erickzhao commented Nov 19, 2025

Adds yarn make to our test + post-merge flows.

Did a bit of cleanup for our workflows in general:

  • Aligned .nvmrc with the version we use for releasing/testing.
  • Updated @types/node to latest 22.

Note that these artifacts are unsigned.

@erickzhao erickzhao changed the title build: add build.yml workflow ci: add build.yml workflow Nov 19, 2025
@socket-security
Copy link

socket-security bot commented Nov 19, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​types/​node@​22.10.10 ⏵ 22.19.1100 +110081 +195 +1100

View full report

@coveralls
Copy link

coveralls commented Nov 19, 2025

Coverage Status

coverage: 79.531% (-0.01%) from 79.543%
when pulling b4e0048 on build-workflow
into 5d25716 on main.

@erickzhao erickzhao marked this pull request as ready for review November 19, 2025 01:14
@erickzhao erickzhao requested review from a team and codebytere as code owners November 19, 2025 01:14
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on Slack refactoring this to avoid a double build situation for the release workflow.

BlackHole1

This comment was marked as outdated.

@BlackHole1 BlackHole1 self-requested a review November 19, 2025 04:12
@erickzhao erickzhao requested a review from dsanders11 November 19, 2025 18:56
@erickzhao erickzhao changed the title ci: add build.yml workflow ci: add universal builds for macOS Nov 19, 2025
@erickzhao
Copy link
Member Author

Added a universal build as well here!

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • Is there much benefit to adding a universal macOS build this late in the game? Not sure it's worth introducing, TBH
  • Not sure we want to upload the artifacts for these builds. The artifacts will total several gigabyte for each run given all the variants, that's going to eat a lot of space quickly.

@erickzhao
Copy link
Member Author

Is there much benefit to adding a universal macOS build this late in the game? Not sure it's worth introducing, TBH

@dsanders11 this stems from a previous Slack discussion we had about the Fiddle download page. Browser support for architecture detection is spotty and intrusive for users, so providing a single universal target is the easiest way of shipping the correct architecture for all users.

Looking at the download stats, we're still on 2/3 arm64 vs 1/3 x64 downloads for macOS.

Not sure we want to upload the artifacts for these builds. The artifacts will total several gigabyte for each run given all the variants, that's going to eat a lot of space quickly.

Good point. Looks like the free GHA limits are relatively low: https://docs.github.com/en/billing/concepts/product-billing/github-actions#free-use-of-github-actions

@erickzhao erickzhao changed the title ci: add universal builds for macOS ci: add builds to test workflows Nov 19, 2025
@erickzhao
Copy link
Member Author

Had a brief discussion with @dsanders11. Going to add Universal in a follow-up if we choose to add the target.

@erickzhao erickzhao merged commit 48bf04e into main Nov 19, 2025
16 checks passed
@erickzhao erickzhao deleted the build-workflow branch November 19, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants