Skip to content

fix(gist): change label to secret (not private) #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlackHole1 merged 2 commits into from
Nov 18, 2025
+8 −8
Merged

fix(gist): change label to secret (not private) #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
617f394
fix(gist): secret (not private)
erickzhao Nov 18, 2025
2340500
test name too
erickzhao Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rtl-spec/components/commands-publish-button.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ describe('Action button component', () => {
expect(state.editorMosaic.isEdited).toBe(true);
});

it('can publish private gists', async () => {
it('can publish secret gists', async () => {
state.showInputDialog = vi.fn().mockResolvedValueOnce(description);
instance.setPrivate();
instance.setSecret();
await instance.performGistAction();
const { create } = mocktokit.gists;
expect(create).toHaveBeenCalledWith({
Expand Down Expand Up @@ -374,7 +374,7 @@ describe('Action button component', () => {
instance.setPublic();
expect(state.gitHubPublishAsPublic).toBe(true);

instance.setPrivate();
instance.setSecret();
expect(state.gitHubPublishAsPublic).toBe(false);
});
});
Expand Down
10 changes: 5 additions & 5 deletions src/renderer/components/commands-action-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const GistActionButton = observer(
super(props);
this.handleClick = this.handleClick.bind(this);
this.performGistAction = this.performGistAction.bind(this);
this.setPrivate = this.setPrivate.bind(this);
this.setSecret = this.setSecret.bind(this);
this.setPublic = this.setPublic.bind(this);

this.state = {
Expand Down Expand Up @@ -298,9 +298,9 @@ export const GistActionButton = observer(
}

/**
* Publish fiddles as private.
* Publish fiddles as secret.
*/
public setPrivate() {
public setSecret() {
this.setPrivacy(false);
}

Expand Down Expand Up @@ -414,10 +414,10 @@ export const GistActionButton = observer(
const privacyMenu = (
<Menu>
<MenuItem
text="Private"
text="Secret"
icon="lock"
active={!gitHubPublishAsPublic}
onClick={this.setPrivate}
onClick={this.setSecret}
/>
<MenuItem
text="Public"
Expand Down
Loading