feat: add integrity digest management commands and functionality#380
feat: add integrity digest management commands and functionality#380nmggithub wants to merge 3 commits intoelectron:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@VerteDinde I saw the Prettier message in the CI run. Sorry about that! Should be good to go now. |
|
Just curious, when do we want to merge this in? From what I understand, the changes this interacts with are in Electron 41, which just recently had its Alpha release. Do we want to wait until the Beta, or even the Stable release? Or can we merge it in now? |
|
Ah, thanks for the reminder ping @nmggithub. cc @electron/wg-ecosystem this needs a review and we should get a new release out before the next stable version drops. |
| digestLogger('\tDigest (SHA256): %s', digest.sha256Digest.toString('hex')); | ||
| break; | ||
| default: | ||
| digestLogger('\tUnknown metadata for digest version: %d', digest.version); |
There was a problem hiding this comment.
I might want to change this message to be something more descriptive like "unexpected digest version", but that reads more like an error not an info. Perhaps the current message is fine.
2 participants
This is to add support for the additional integrity digest API I am adding in this pull request: electron/electron#48587. I believe this package is the best place to put this functionality. Once merged, this functionality can be pulled into tools like Electron Forge as needed.