base64 dense vector packing #1499
Open
+260
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
base64-dense-vector-packing
branch
3 times, most recently
from
be47e77 to
aa4b389
Compare
miguelgrinberg
force-pushed
the
base64-dense-vector-packing
branch
from
aa4b389 to
34a8090
Compare
| $doc = $dataset[($i - 1) % $len]; | ||
| $params['body'][] = ['index' => ['_index' => $index]]; | ||
| $params['body'][] = [ | ||
| 'docid' => $doc['docid'], |
Member
There was a problem hiding this comment.
I think we're supposed to leave out the docid in the benchmark.
Contributor
Author
There was a problem hiding this comment.
I believe that refers to not using the docid as the document id. This puts it as a regular field, which I saw others do as well. I don't think it will make any significant difference with or without this field, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elastic\Elasticsearch\Helper\Vectors::packDenseVector()function to pack dense vectors for efficient bulk uploading to Elasticsearch. Also included in this PR is a benchmark for this feature.