Makefile: timing-root: don't always create dir#242
Open
xobs wants to merge 1 commit intoefabless:mainfrom
Open
Makefile: timing-root: don't always create dir#242xobs wants to merge 1 commit intoefabless:mainfrom
xobs wants to merge 1 commit intoefabless:mainfrom
Conversation
Don't always create the `dependencies/` directory, because the `TIMING_ROOT` may not be in the current project. Instead, create the `TIMING_ROOT` directory. If this does not exist, then the `mkdir` will succeed. If it does exist, then this target will not get run. `git` will clone into an empty directory, so for most users this will not change the flow at all. This change prevents an empty `dependencies` directory from getting created as part of `make setup`. Signed-off-by: Sean Cross <sean@xobs.io>
kareefardi
approved these changes
Jun 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't always create the
dependencies/directory, because theTIMING_ROOTmay not be in the current project.Instead, create the
TIMING_ROOTdirectory. If this does not exist, then themkdirwill succeed. If it does exist, then this target will not get run.gitwill clone into an empty directory, so for most users this will not change the flow at all.This change prevents an empty
dependenciesdirectory from getting created as part ofmake setup.