Revert "AUT-31 code changes & implementation for redirection from Legacy page to new Authn MFE"

[ferdis]

Reverts #60

[Copilot]

Pull request overview

This PR reverts changes from PR #60 that implemented redirection from legacy authentication pages to the new Authn MFE for enterprise customers with specific TPA and SAML configurations.

Changes:

• Removes enterprise/TPA/SAML conditional logic from the should_redirect_to_authn_microfrontend() function
• Reverts the boolean environment variable handling for ENABLE_AUTHN_MICROFRONTEND from string comparison back to direct os.environ.get()

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openedx/core/djangoapps/user_authn/toggles.py	Simplifies the authn MFE redirect logic by removing enterprise/TPA/SAML conditional checks
lms/envs/common.py	Changes environment variable handling for ENABLE_AUTHN_MICROFRONTEND setting

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The use of os.environ.get("EDXAPP_ENABLE_AUTHN_MFE", False) is problematic because when the environment variable is set, it returns a string (e.g., "true", "false", "1", "0"), not a boolean. In Python, any non-empty string is truthy, meaning even setting EDXAPP_ENABLE_AUTHN_MFE="false" would evaluate to True.

This differs from the code being reverted which used .lower() == "true" to properly convert the string to a boolean. The current implementation will incorrectly enable the authn microfrontend whenever the environment variable is set to any non-empty value.

Consider using a proper boolean conversion such as:

• os.getenv("EDXAPP_ENABLE_AUTHN_MFE", "false").lower() == "true"
• Or a helper function that safely converts string values to booleans

Suggested change

	ENABLE_AUTHN_MICROFRONTEND = os.environ.get("EDXAPP_ENABLE_AUTHN_MFE", False)
	ENABLE_AUTHN_MICROFRONTEND = os.getenv("EDXAPP_ENABLE_AUTHN_MFE", "false").lower() == "true"