fix: Updating check python dependencies for setuptools#116
fix: Updating check python dependencies for setuptools#116ktyagiapphelix2u wants to merge 4 commits intorelease-ulmofrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow that checks Python dependencies by ensuring setuptools is available during the run.
Changes:
- Adds a step to upgrade/install
pipandsetuptoolsbefore runningfind_python_dependencies. - Removes the standalone (and misspelled) setuptools install step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Upgrade pip and setuptools | ||
| run: python -m pip install --upgrade pip setuptools |
There was a problem hiding this comment.
This workflow installs the latest pip/setuptools via --upgrade, which bypasses the repo’s pinned toolchain in requirements/pip.txt (e.g., pip==25.2, setuptools==80.9.0). Using unpinned latest versions can make CI nondeterministic or break unexpectedly. Consider installing from requirements/pip.txt (and include wheel if needed) to keep this workflow consistent with the other Python workflows.
| - name: Upgrade pip and setuptools | |
| run: python -m pip install --upgrade pip setuptools | |
| - name: Install pinned Python packaging tools | |
| run: python -m pip install -r requirements/pip.txt |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
No description provided.