Fix vulnerabilities, update most packages to latest version, update minimum node version to 18#466
Open
yehudab wants to merge 19 commits intoeduardoboucas:masterfrom
Open
Fix vulnerabilities, update most packages to latest version, update minimum node version to 18#466yehudab wants to merge 19 commits intoeduardoboucas:masterfrom
yehudab wants to merge 19 commits intoeduardoboucas:masterfrom
Conversation
|
Thanks, man... I will use your changes ;) |
saidmoglu
reviewed
Apr 22, 2025
saidmoglu
left a comment
saidmoglu
left a comment
There was a problem hiding this comment.
fixing 2 bugs with github app based auth
| const app = new App( | ||
| const appAuth = createAppAuth( | ||
| { | ||
| id: config.get('githubAppID'), |
There was a problem hiding this comment.
it needs to be
appId: config.get('githubAppID'),
| const installationId = data.id | ||
| const installationAuth = createAppAuth( | ||
| { | ||
| id: config.get('githubAppID'), |
There was a problem hiding this comment.
same as above
appId: config.get('githubAppID'),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another attempt at fixing #375.
There are currently 5 moderate vulnerabilities.
I don't think it should be merged, but maybe can be used as a baseline for further improvements. All automatic tests are passing, but I can't guarantee that it actually works in all scenarios. I'm using it with GitHub and it works fine.
Most unverified changes were done with GitLab and maligun packages.