ci: add tests for PHP 8.5

[Chris53897]

PHPStan run for PHP 8.5 has a lot of warnings.
That is the reason it is disabled.

If PHP min is changed to 7.4, PHPStan could be bumped to version 2.

[mstruebing]

Hey thank you for this PR! 🚀
I'm not opposed to merging this but would it be in scope of this PR to fix the warnings?

If not, if it's only warnings, should we still enable to be a least aware that there is something to do?

[janedbal]

I dont think this it good idea, it should pass all PHP versions. Rather fix the issues.

[Chris53897]

Running Phpstan 1|2 to Support all PHP Versionen and run will raise different Warnings. I can give it a try later. In my opinion phpstan should not run for all PHP versions. I guess bumping min Version of PHP to 7.4 ist not an Option for you

[mstruebing]

Just had a look at the official PHP support site, 7.4 and even 8.0 are end of life already.

we shouldn’t worry to much about supporting unsupported PHP versions on my opinion.

https://www.php.net/supported-versions.php

what do you think @janedbal ?

[janedbal]

We can drop old PHP if it causes issues. But it does not. PHPStan 1.12.32 works well on PHP 8.5, just upgrade it.

[Chris53897]

Sorry i did not noticed that it used composer install and composer.lock needs to be regnerated.
I am not sure how to handle the warning

[mstruebing]

Something like the following could work:

$isArgvSet = array_key_exists('argv', get_defined_vars());
$args = $isArgvSet ? $argv : [];
$result = Cli::run($args);

Note: I did not do PHP for a lot of years, so there might be better ways and I did not test it.