-
Notifications
You must be signed in to change notification settings - Fork 106
feature(service): Add Whimsical and Figma services #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
neSpecc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Please, add corresponded tests, increment a patch version and update a service-list in readme
|
@thooams hey. Are you going to update the PR? |
|
Yes. I have to find the time to do it |
|
Tests are written. |
neSpecc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
increment a patch version, please
neSpecc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update a list in Readme, please
|
Please, update the branch |
neSpecc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, remove all changes unrelated to new services
|
Unexpected changes were removed |
|
Thanks @thooams |
No description provided.