Skip to content

Conversation

@thooams
Copy link
Contributor

@thooams thooams commented Mar 26, 2024

No description provided.

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Please, add corresponded tests, increment a patch version and update a service-list in readme

@neSpecc
Copy link
Contributor

neSpecc commented Apr 3, 2024

@thooams hey. Are you going to update the PR?

@thooams
Copy link
Contributor Author

thooams commented Apr 3, 2024

Yes. I have to find the time to do it

@thooams thooams changed the title feataure(service): Add Whimsical and Figma services feature(service): Add Whimsical and Figma services Apr 23, 2024
@thooams
Copy link
Contributor Author

thooams commented Apr 23, 2024

Tests are written.

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increment a patch version, please

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update a list in Readme, please

@neSpecc
Copy link
Contributor

neSpecc commented Oct 12, 2024

Please, update the branch

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, remove all changes unrelated to new services

@thooams
Copy link
Contributor Author

thooams commented Oct 18, 2024

Unexpected changes were removed

@neSpecc neSpecc merged commit 863834c into editor-js:master Nov 21, 2025
1 check passed
@neSpecc
Copy link
Contributor

neSpecc commented Nov 21, 2025

Thanks @thooams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants