🚀🚀🚀🚀 Basic functionality for collaborative editing#102
Merged
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 909766f
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 99.76% (+3.78% 🔼) |
815/817 |
| 🟢 | Branches | 98.65% (+2.65% 🔼) |
220/223 |
| 🟢 | Functions | 98.5% (+10.83% 🔼) |
197/200 |
| 🟢 | Lines | 99.75% (+3.91% 🔼) |
785/787 |
Test suite run success
418 tests passing in 25 suites.
Report generated by 🧪jest coverage report action from 909766f
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 68% | 17/25 |
| 🔴 | Branches | 20% | 1/5 |
| 🟢 | Functions | 83.33% | 5/6 |
| 🟡 | Lines | 65.22% | 15/23 |
Test suite run success
3 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 909766f
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 68.35% (-31.65% 🔻) |
162/237 |
| 🟢 | Branches | 81.33% (-16.23% 🔻) |
61/75 |
| 🔴 | Functions | 58.82% (-34.03% 🔻) |
20/34 |
| 🟡 | Lines | 68.38% (-31.62% 🔻) |
160/234 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / MessageType.ts |
100% | 100% | 100% | 100% |
| 🔴 | client/OTClient.ts | 0% | 0% | 0% | 0% |
| 🟢 | CollaborationManager.ts | 86.76% | 78.26% | 71.43% | 86.76% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | Operation.ts | 96% (-4% 🔻) |
96% (-4% 🔻) |
83.33% (-16.67% 🔻) |
96% (-4% 🔻) |
Test suite run success
67 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 909766f
|
⏭️ No files to mutate for |
|
⏭️ No files to mutate for |
packages/core/src/entities/index.ts
Outdated
Comment on lines
1
to
3
| export type * from './Config.js'; | ||
| export type * from './UnifiedToolConfig.js'; | ||
| export type * from './EditorjsPlugin.js'; |
There was a problem hiding this comment.
The usage of 'export type *' is not valid TypeScript syntax. Consider using 'export * from' or the appropriate named type exports instead.
Suggested change
| export type * from './Config.js'; | |
| export type * from './UnifiedToolConfig.js'; | |
| export type * from './EditorjsPlugin.js'; | |
| export * from './Config.js'; | |
| export * from './UnifiedToolConfig.js'; | |
| export * from './EditorjsPlugin.js'; |
e11sy
reviewed
Apr 9, 2025
| if (message.payload.userId === this.#userId) { | ||
| return; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
transform undo/redo stack on remote operations
Contributor
There was a problem hiding this comment.
could be done in a separate pr
neSpecc
reviewed
Apr 9, 2025
packages/ui/vite.config.ts.timestamp-1744233098859-624e58abb13.mjs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
Co-authored-by: Peter <specc.dev@gmail.com>
…re/collaborative-editing
neSpecc
approved these changes
Apr 10, 2025
e11sy
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.