Skip to content

Conversation

@sdoyle88
Copy link
Contributor

Overview

First, thank you for a great project! I have been playing around with ECA, and it's a great package. However, with Corfu enabled, autocompletions did not work with the / command if I had an MCP configuration with a nil description.

For example, with the flux-mcp server

eca-chat--completion-prompts-annotate(#("flux-operator-mcp:debug_flux_helmrelease" 0 40 
(eca-chat-completion-item (:name "flux-operator-mcp:debug_flux_helmrelease" :description nil :arguments 
[(:name "name" :description "The name of the Flux resource." :required t)
 (:name "namespace" :description "The namespace of the Flux resource." :required t) 
(:name "cluster" :description "The context name of the cluster, defaults to current." :required nil)] :type "mcpPrompt"))))

Note that the description is nil, and this causes a corfu error. With the update of the eca-chat--completion-prompts-annotate function, this allows for us to check if this is nil and if it is handle it gracefully. Happy if you want to adjust this in any way, just a simple fix I found for a small bug

image.

Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
And yes, that makes sense, thanks again!

@ericdallo ericdallo merged commit b97d50d into editor-code-assistant:master Oct 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants