Fix ediff unknown terminal type error with plain window setup #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdallo
reviewed
Oct 9, 2025
eca-diff.el
Outdated
Comment on lines
188
to
190
| (progn | ||
| (setq ediff-window-setup-function 'ediff-setup-windows-plain) | ||
| (ediff-buffers buf-orig buf-new)) |
Member
There was a problem hiding this comment.
I think this set a variable that can change this ediff behavior on other modes and usages of other packages, we should do something like this I think:
Suggested change
| (progn | |
| (setq ediff-window-setup-function 'ediff-setup-windows-plain) | |
| (ediff-buffers buf-orig buf-new)) | |
| (let ((ediff-window-setup-function 'ediff-setup-windows-plain)) | |
| (ediff-buffers buf-orig buf-new)) |
zikajk
force-pushed
the
fix-ediff-diff-for-new-files
branch
from
e31dd80 to
dbb104e
Compare
ericdallo
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.