Skip to content

feat(ampsync): configurable destination table #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matiasedgeandnode wants to merge 2 commits into
base: main
Choose a base branch
from
+453 −93
Open

feat(ampsync): configurable destination table #1988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b12ddc5
feat(ampsync): configurable destination table
matiasedgeandnode Mar 17, 2026
ea7feec
f: PR comments
matiasedgeandnode Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions crates/bin/ampsync/src/commands/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ use anyhow::{Context, Result};
use sqlx::postgres::PgPoolOptions;
use tracing::info;

use crate::{config::SyncConfig, engine::Engine, health, manager::StreamManager};
use crate::{
config::{self, SyncConfig},
engine::Engine,
health,
manager::StreamManager,
};

pub async fn run(config: SyncConfig) -> Result<()> {
info!("Starting ampsync");
Expand All @@ -22,18 +27,31 @@ pub async fn run(config: SyncConfig) -> Result<()> {
.context("Failed to run state store migrations")?;
info!("State store migrations complete");

info!("Tables to sync: {} tables", config.tables.len());
for table_name in &config.tables {
info!(" - {}", table_name);
}

// Create engine
let engine = Engine::new(pool.clone());

// Convert PartialReference to full Reference by filling in defaults
let dataset = config.dataset.to_full_reference();
info!("Dataset: {}", dataset);

// Build table mappings (source → destination) based on suffix/version config
let mappings = config::build_table_mappings(
&config.tables,
&dataset,
config.table_version,
config.table_suffix.as_deref(),
)
.context("Failed to build table mappings")?;

info!("Tables to sync: {} tables", mappings.len());
for mapping in &mappings {
if mapping.source == mapping.destination {
info!(" - {}", mapping.source);
} else {
info!(" - {} -> {}", mapping.source, mapping.destination);
}
}

// Create streaming client
let grpc_max_decode_bytes = config.grpc_max_decode_mb as usize * 1024 * 1024;
info!(
Expand All @@ -56,7 +74,7 @@ pub async fn run(config: SyncConfig) -> Result<()> {
info!("Amp client initialized");

// Spawn streaming tasks (table creation happens in StreamTask::new)
let manager = StreamManager::new(&config.tables, dataset, &config, engine, client, pool);
let manager = StreamManager::new(&mappings, dataset, &config, engine, client, pool);

// Start health server if configured
if let Some(port) = config.health_port {
Expand Down
Loading
Loading