feat(ampsync): add configurable index creation on table setup#1985
Open
matiasedgeandnode wants to merge 1 commit intomainfrom
Open
feat(ampsync): add configurable index creation on table setup#1985matiasedgeandnode wants to merge 1 commit intomainfrom
matiasedgeandnode wants to merge 1 commit intomainfrom
Conversation
910a945 to
1719948
Compare
1719948 to
dbd9bf6
Compare
tmigone
reviewed
Mar 17, 2026
| /// See the "Index Configuration" section in the crate README for format details. | ||
| /// | ||
| /// Can also be set via AMPSYNC_CONFIG environment variable | ||
| #[arg(long, env = "AMPSYNC_CONFIG")] |
Member
There was a problem hiding this comment.
I suggest using a different name here, index-config or something like that. Otherwise it sounds like the configuration file to run ampsync, where i would expect to be able to set things like auth, table, etc (basically all other config).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--config/AMPSYNC_CONFIGoption to specify a TOML file with index definitionsConfig example
Test plan