fix(amp-worker-core): compaction skips latest segments#1969
Merged
Conversation
Theodus
changed the title
Collaborator
|
Current behaviour is intentional. In the principle that if we're compacting then we might as well try to pack the group as optimally as possible. If very recent files gen 0 should be excluded due to the reorg problem, that should imo have a specific mechanism for preventing compaction of recent files. |
Theodus
force-pushed
the
theodus/compaction
branch
from
2b7eae7 to
96586f2
Compare
Member
Author
|
@leoyvens, updated to only prevent raw files from starting/joining the compaction group until cooldown. |
Theodus
force-pushed
the
theodus/compaction
branch
from
96586f2 to
c7cc040
Compare
Theodus
changed the title
Theodus
changed the title
Theodus
force-pushed
the
theodus/compaction
branch
2 times, most recently
from
c5a7f6a to
291cc4d
Compare
Theodus
changed the title
leoyvens
reviewed
Mar 16, 2026
Theodus
force-pushed
the
theodus/compaction
branch
from
291cc4d to
79e2a5a
Compare
Add a `skip_latest_segments` config option (default: 3) that drops the last N segments from the canonical chain before compaction planning. This avoids compacting recently-written data that may contain reorganized blocks.
Theodus
force-pushed
the
theodus/compaction
branch
from
79e2a5a to
218bac7
Compare
Theodus
changed the title
leoyvens
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
skip_latest_segmentsconfig option (default: 3) that drops the last N segments from the canonical chain before compaction planning. This avoids compacting recently-written data that may contain reorganized blocks.