Skip to content

Conversation

@suiso67
Copy link

@suiso67 suiso67 commented Feb 6, 2025

Reader

  • Fixed action bar overlapping system bar

Preferences

  • Add preferences screen

Configurable Navigation Overlay Activation Type

  • Long tap(default behavior)
  • Single tap
  • Single tap allowing double tap to zoom

Adjustable Touch Area Size

  • Seek bar will adjust touch area size for page turning between 10% ~ 30% of screen width

Misc.

  • Add gradle wrapper

@edeso
Copy link
Owner

edeso commented Feb 6, 2025

thanks for contributing. it's quite a lot of changes in one PR though.

please separate them into one PR per change and add a detailed description what it is supposed to fix or implement. what is missing/not working before this change is committed?

you can omit

refactor: add gradle wrapper as i'd rather generated them locally and pushed them already

refactor: remove commented dependencies already as these commented entries are needed for now.

these need explanations

feat: keep main activity below system bar
why? having the ui translucent above the comic was a conscious design decision. what is your issue that you need this disabled?

feat: add reader overlay for enhanced navigation ui
this is merely a renaming refactoring plus android:fitsSystemWindows="true" which is disabled by design. same question, why?

feat: show navigation overlay on single touch, not long press, feat: move reader navigation activation mode into preferences
again, long press was a conscious decision to prevent accidential menu activations as in the original Bubble app. the configurable option is a nice touch. but actually i'd rather switch to a drag down from, drag up from bottom for default menu activation in reader.

feat: revert reader navigation overlay style
you lost me here. what is this supposed to solve?

feat: support adjustable reader navigation touch area size, feat: add title and summary to preferences screen
that needs more explanation to the user and i feel this is over-costumization. i strive for simple but elegant with Bubble2

under consideration is

refactor: clean up navigation touch listener
s a refactoring that changes no functionality still i see that it has a cleaner approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants