-
Notifications
You must be signed in to change notification settings - Fork 234
internal_config feature removal
#2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove `internal_config` feature * after-merge fix --------- Co-authored-by: Michael Ilyin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2352 +/- ##
=======================================
Coverage 71.88% 71.88%
=======================================
Files 387 387
Lines 61972 61961 -11
=======================================
- Hits 44546 44540 -6
+ Misses 17426 17421 -5 ☔ View full report in Codecov by Sentry. |
DenisBiryukov91
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
The PR removes
internal_configfeature usage from the codebaseWhy is this change needed?
It was decided to remove the "internal_config" feature in #1655 and the removal was done on #1939.
That PR was reverted in #2031 because it caused CI failure on API compatibility check which is hard to reconfigure.
This PR makes the removal in a safe way: it removes usage of
internal_configfeature, but keeps it in Cargo.toml as a dummy entry, keeping the API formally compatible,To finish the fix it it's necessary to temporary disable the check, make release with changed API (without
internal_configfeature) and restore the check, pointing to new release. This can be done separately.Related Issues
Partially fixes #1655
Contains the reverted #1939 with changes
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
enhancement✨ Enhancement Requirements
Since this PR enhances existing functionality:
Remember: Enhancements should not introduce new APIs or breaking changes.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.