Skip to content

Conversation

@milyin
Copy link
Contributor

@milyin milyin commented Dec 5, 2025

implementation for #692

  • implemented transports() and links() methods
  • implemented transport_events_listener() and link_events_listener() methods
  • test added
  • z_info example demonstrates new functionality
  • adminspace uses the connectivity api, no separate implementation
  • the adminspace keys @/<local_zid>/session/transport/(multicast|unicast)/<remote_zid> and @/<local_zid>/session/transport/(multicast|unicast)/<remote_zid>/link/<link_id> works as before, but uses the new API. The keeping the same adminspace behavior is ensured by test Connectivity adminspace test #2334
  • the priority and reliability for Link are none if transport doesn't support qos
  • the reliability is derived from the link protocol if not configured explicitly

🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: new feature

🆕 New Feature Requirements

Since this PR adds a new feature:

  • Feature scope documented - Clear description of what the feature does and why it's needed
  • Minimum necessary code - Implementation is as simple as possible, doesn't overcomplicate the system
  • New APIs well-designed - Public APIs are intuitive, consistent with existing APIs
  • Comprehensive tests - All functionality is tested (happy path + edge cases + error cases)
  • Examples provided - Usage examples in code comments or separate example files
  • Documentation added - New docs explaining the feature, its use cases, and API
  • Feature flag considered - Can the feature be enabled/disabled for gradual rollout?
  • Performance impact assessed - Memory, CPU, storage implications measured
  • Integration tested - Feature works with existing features

Consider: Can this feature be split into smaller, incremental PRs?

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 72.74701% with 251 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.98%. Comparing base (61f07d5) to head (97a106b).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
zenoh/src/api/info.rs 53.89% 77 Missing ⚠️
zenoh/src/api/builders/info_links.rs 57.24% 59 Missing ⚠️
zenoh/src/api/builders/info_transport.rs 67.18% 42 Missing ⚠️
zenoh/src/api/session.rs 81.48% 25 Missing ⚠️
zenoh/src/net/runtime/mod.rs 75.26% 23 Missing ⚠️
zenoh/src/api/connectivity.rs 88.88% 9 Missing ⚠️
zenoh/src/api/admin.rs 95.32% 8 Missing ⚠️
commons/zenoh-protocol/src/core/endpoint.rs 0.00% 5 Missing ⚠️
commons/zenoh-protocol/src/core/locator.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   72.06%   71.98%   -0.09%     
==========================================
  Files         387      390       +3     
  Lines       62006    62729     +723     
==========================================
+ Hits        44685    45155     +470     
- Misses      17321    17574     +253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

PR missing one of the required labels: {'breaking-change', 'internal', 'bug', 'new feature', 'documentation', 'ci', 'api-sync', 'enhancement', 'dependencies'}

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

PR missing one of the required labels: {'new feature', 'internal', 'api-sync', 'enhancement', 'documentation', 'breaking-change', 'ci', 'dependencies', 'bug'}

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

PR missing one of the required labels: {'internal', 'bug', 'new feature', 'breaking-change', 'dependencies', 'documentation', 'ci', 'enhancement', 'api-sync'}

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

PR missing one of the required labels: {'enhancement', 'new feature', 'breaking-change', 'internal', 'api-sync', 'bug', 'ci', 'dependencies', 'documentation'}

@milyin milyin added the new feature Something new is needed label Dec 6, 2025
@milyin milyin marked this pull request as draft January 13, 2026 13:41
@milyin milyin marked this pull request as ready for review January 13, 2026 15:47
@milyin milyin marked this pull request as draft January 14, 2026 09:04
@milyin milyin marked this pull request as ready for review January 14, 2026 23:53
@milyin milyin merged commit 279e768 into main Jan 14, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Something new is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants