Skip to content

Reorg SHM examples #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yellowhatter wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Reorg SHM examples #2209

yellowhatter wants to merge 10 commits into from

Conversation

@yellowhatter
Copy link
Contributor

@yellowhatter yellowhatter commented Oct 17, 2025 •
edited
Loading

  • reorganize shm examples
  • add custom shm provider backend example
  • add shm provider backend selection example

@yellowhatter
- reorganize shm examples
4e45879 
- add custom shm provider example
@yellowhatter yellowhatter self-assigned this Oct 17, 2025
@yellowhatter yellowhatter added the enhancement Existing things could work better label Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.86%. Comparing base (636f431) to head (6c5b5cf).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2209      +/-   ##
==========================================
+ Coverage   71.84%   71.86%   +0.01%     
==========================================
  Files         377      377              
  Lines       61281    61272       -9     
==========================================
+ Hits        44030    44035       +5     
+ Misses      17251    17237      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yellowhatter yellowhatter added the release Part of the next release label Oct 31, 2025
evshary
evshary reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks

commons/zenoh-shm/src/api/provider/memory_layout.rs

impl From<&MemoryLayout> for core::alloc::Layout {
fn from(value: &MemoryLayout) -> Self {
// SAFERY: this is safe because `MemoryLayout`'s size and alignment are already checked
Copy link
Contributor

@evshary evshary Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAFETY?

examples/examples/shm/z_custom_shm_provider.rs
@@ -0,0 +1,262 @@
//
// Copyright (c) 2023 ZettaScale Technology
Copy link
Contributor

@evshary evshary Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use 2025 as this is a new file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evshary evshary evshary left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yellowhatter yellowhatter

Labels

enhancement Existing things could work better release Part of the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yellowhatter @evshary