Skip to content

Conversation

@MaximilianToe
Copy link
Contributor

This PR updates the signature of cleanupListener to use a const reference to be compatible with the latest version of up-cpp.

closes #25

@PLeVasseur
Copy link
Contributor

Hi @MaximilianToe -- thank you for the contribution! Looks like something fell over in CI when referencing up-core-api in Conan. Could you take a look?

@PLeVasseur
Copy link
Contributor

I suppose our pattern can be:

  1. I spin the CI, we see what still is in need of updates, if nothing go to 4.
  2. You make the update(s)
  3. Go back to 1.
  4. Escape loop :)

@MaximilianToe
Copy link
Contributor Author

I fixed a few errors in the Pipeline. The only remaining errors in the CI should now originate from SocketUTransport in the up-tck repo. I made a separate PR there to update the signature and the up-cpp version. If that PR is approved, the CI here should also work.

eclipse-uprotocol/up-tck#115

@PLeVasseur
Copy link
Contributor

Hey @MaximilianToe -- let's discuss in our meeting on Wednesday how to handle the up-tck failure. We need to rescope up-tck a bit in any case.

@PLeVasseur
Copy link
Contributor

Thanks for clearing this up @MaximilianToe 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update method signature after recent change in up-cpp

2 participants