Skip to content

Conversation

@AndrYurk
Copy link
Contributor

@AndrYurk AndrYurk commented Mar 6, 2025

Description

This PR provide fix for the "Management API Tests" postman collection. For this data-service usability was improved(added ingress configuration and changed return type for "/v1/data" POST endpoint). Also was fixed compilation of tx-issuerservice and updated
mxd README file with proper images from the mxd-runtimes.

Fixes #476

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@AndrYurk AndrYurk requested review from lgblaumeiser, ndr-brt and rafaelmag110 and removed request for paullatzelsperger March 6, 2025 13:49
@rafaelmag110
Copy link
Contributor

Some of these changes would deserve their own PR, as that would increase commit history transparency. Please try to split things up next time. As soon as you placed that comma in the PR title, you should have noticed that this could have been two.

@rafaelmag110 rafaelmag110 merged commit 13f24de into eclipse-tractusx:main Mar 12, 2025
7 checks passed
@AndrYurk AndrYurk deleted the postman-managment-test-collection branch March 12, 2025 16:49
@AndrYurk
Copy link
Contributor Author

@rafaelmag110 , thanks for the clarification. Next time, in a similar case, would a separate PRs be sufficient, or should a separate issue also be created?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants