[Win32] Process DPI change events via OS instead of Display#asyncExec #2946
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asynchronous processing of DPI change events is currently done by processing the event for each control via Display#asyncExec. This has several drawbacks: - the events are processed rather late (even after earlier scheduled, lower-priority business events - the events may not be processed while dragging a shell to another monitor in case a browser currently has focus - the events are not processed at all if a Synchronizer is used that does not process async events (such as for an Eclipse workspace during startup) This change replaces the usage of Display#asyncExec for asynchronous processing of DPI events with a timer message sent via the OS and a queue maintained in every control for the events to process. WM_TIMER events are used as they are processed with low priority by the OS but still with higher priority by SWT than any business-logic-side tasks scheduled at a Display instance.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchronous processing of DPI change events is currently done by processing the event for each control via Display#asyncExec. This has several drawbacks:
This change replaces the usage of Display#asyncExec for asynchronous processing of DPI events with a timer message sent via the OS and a queue maintained in every control for the events to process. WM_TIMER events are used as they are processed with low priority by the OS but still with higher priority by SWT than any business-logic-side tasks scheduled at a Display instance.