feat: Make use of SVG graphics #1458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses (1) and (2) of #1456
Note: I assumed that the SVG files in the
/svgare otherwise unused and were just kept in case we needed to generate higher resolution pngs. Is this correct?org.eclipse.lsp4e\icons\fullmark_occurences.svg. As far as I can tell this file was unused.LSPImagesexhaustive and add missing cases for Constant and TypeParameter. If future updates of LSP4J add more symbolkinds, the compiler will warn us, that the switch-case is now incomplete and we need to add a case. I'm not sure if this is a somehow breaking change, i.e., I'm not sure what would happen if a user for some reason would use a newer version of LSP4J with additional enum values. Though I'm not sure if this is a supported use-case?boolean.svgto 16x16 (same as all other svg). Without this change, the image scaling at higher display scaling produced this:with the changed size, it looked like this:

platform:/plugin/org.eclipse.ui/icons/full/elcl16/collapseall.svginstead of...collapseall.png