fix: Stop processing resource changes when dispatcher was shutdown #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianKroiss
force-pushed
the
resource-shutdown
branch
from
b3078c4 to
62119e3
Compare
Contributor
|
How do you think this can happen? A race condition when the server is stop? Maybe when org.eclipse.lsp4e.LanguageServerPlugin.stop(BundleContext) is called? |
Contributor
Author
|
Yes, org.eclipse.lsp4e.LanguageServerPlugin.stop(BundleContext) has been called but the ResourceChangeListener is still registered. And the context in the LanguageServerWrapper has not been stopped yet. A better solution can probably be achieved if we address #681 some day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1446
I was unable to reliably reproduce the error, so I am not 100 percent sure that this fix will work, but to me it seems logical that it should workUsing breakpoints in the Plugin Shutdown and the ResourceChangeListener, I was able to confirm that the patch works as expected.