feat: support linked inline editing on rename #1440
Conversation
org.eclipse.lsp4e/src/org/eclipse/lsp4e/internal/IdentifierUtil.java
Outdated
Show resolved
Hide resolved
| * Delegates to {@link Character#isUnicodeIdentifierPart}. | ||
| */ | ||
| public static boolean isIdentifierPart(final char ch) { | ||
| return Character.isUnicodeIdentifierPart(ch); |
There was a problem hiding this comment.
from the documentation, it is clear that we are handling '_' as before, but what about '$'?
There was a problem hiding this comment.
I added the isWordPart method as part of #1375 which also included '$'. In all other places of the codebase we do not check for '$' but only use Character.isUnicodeIdentifierPart() So to be consistent I think not checking for $ is actually the right call.
There was a problem hiding this comment.
I am a bit hesitant because '$' can be part of an identifier in some languages (at least java allows them, and we in my company extensevily used '$' in identifiers for our own languages) but since this only affects a fallback in case the LS is not responding fast enough, and even then, it would only reduce the number of calls to hovers, I think we can try it if you think it is the right call. Would you mind rebasing and resolving conflicts? Then I would approve and merge it.
There was a problem hiding this comment.
I think it is the right call.
org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/rename/LSPInlineRenameLinkedMode.java
Show resolved
Hide resolved
org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/rename/LSPInlineRenameLinkedMode.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/rename/LSPInlineRenameLinkedMode.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/rename/LSPInlineRenameLinkedMode.java
Show resolved
Hide resolved
org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/rename/LSPInlineRenameLinkedMode.java
Outdated
Show resolved
Hide resolved
sebthom
force-pushed
the
issue-891
branch
2 times, most recently
from
312f6b1 to
e5c2a3d
Compare
rubenporras
left a comment
rubenporras
left a comment
There was a problem hiding this comment.
could you bump the version numbers of the test plugin?
2 participants
Fixes #891