Fix quick-fixes to not add static for well-known JUnit annotations #2773
+111
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add checks in ModifierCorrectionSubProcessorCore.getAddMethodModifierProposal() to look for adding static to an annotation and if it is well-known junit annotations that don't allow static just return - add new tests to ModifierCorrectionsQuickFixTest - fixes eclipse-jdt#2761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Doesn't propose adding static to a method that uses well-known junit annotations such as Test, BeforeEach, Before....
How to test
See issue or new tests.
Author checklist