Skip to content

Offer quick-fix for non-deprecated enum constant in deprecated enum #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjohnstn merged 1 commit into from
Jan 28, 2026
Merged

Offer quick-fix for non-deprecated enum constant in deprecated enum #2765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...t.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/Java50FixCore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.eclipse.jdt.core.dom.BodyDeclaration;
import org.eclipse.jdt.core.dom.ClassInstanceCreation;
import org.eclipse.jdt.core.dom.CompilationUnit;
import org.eclipse.jdt.core.dom.EnumConstantDeclaration;
import org.eclipse.jdt.core.dom.Expression;
import org.eclipse.jdt.core.dom.FieldDeclaration;
import org.eclipse.jdt.core.dom.ITypeBinding;
Expand Down Expand Up @@ -486,7 +487,8 @@ private static ASTNode getDeclaringNode(ASTNode selectedNode) {
declaringNode= selectedNode;
} else if (selectedNode instanceof SimpleName) {
StructuralPropertyDescriptor locationInParent= selectedNode.getLocationInParent();
if (locationInParent == MethodDeclaration.NAME_PROPERTY || locationInParent == TypeDeclaration.NAME_PROPERTY) {
if (locationInParent == MethodDeclaration.NAME_PROPERTY || locationInParent == TypeDeclaration.NAME_PROPERTY
|| locationInParent == EnumConstantDeclaration.NAME_PROPERTY) {
declaringNode= selectedNode.getParent();
} else if (locationInParent == VariableDeclarationFragment.NAME_PROPERTY) {
declaringNode= selectedNode.getParent().getParent();
Expand Down
36 changes: 36 additions & 0 deletions org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/QuickFixTest1d8.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3512,4 +3512,40 @@ public void foo() {
assertExpectedExistInProposals(proposals, new String[] {expected1});
}

@Test
public void testIssue2764() throws Exception {
Hashtable<String, String> options = JavaCore.getOptions();
options.put(JavaCore.COMPILER_PB_DEPRECATION, CompilerOptions.WARNING);
JavaCore.setOptions(options);
IPackageFragment pack2= fSourceFolder.createPackageFragment("test1", false, null);

String str1= """
package test1;

@Deprecated
public enum E {
BAR
}
""";
ICompilationUnit cu= pack2.createCompilationUnit("E.java", str1, false, null);

CompilationUnit astRoot= getASTRoot(cu);
ArrayList<IJavaCompletionProposal> proposals= collectCorrections(cu, astRoot, 1, null);
assertCorrectLabels(proposals);
assertNumberOfProposals(proposals, 2);

String expected1= """
package test1;

@Deprecated
public enum E {
@Deprecated
BAR
}
""";

assertExpectedExistInProposals(proposals, new String[] {expected1});

}

}
Loading