Skip to content

Fix Javadoc hover for char constant that is 0 #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjohnstn merged 1 commit into from
Jan 21, 2026
Merged

Fix Javadoc hover for char constant that is 0 #2750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/hover/JavadocHoverTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,5 +430,36 @@ void foo(){}
assertEquals("sequence doesn't match", expectedCodeSequence, actualSnippet);
}
}

@Test
public void testCharConstant() throws Exception {
String source=
"""
package p;
public class Javadoc {
static final char c = (char)0;
}
""";
ICompilationUnit cu= getWorkingCopy("/TestSetupProject/src/p/Javadoc.java", source, null);
assertNotNull("TestClass.java", cu);

IType type= cu.getType("Javadoc");
// check javadoc on each member:
for (IJavaElement member : type.getChildren()) {
IJavaElement[] elements= { member };
ISourceRange range= ((ISourceReference) member).getNameRange();
JavadocBrowserInformationControlInput hoverInfo= JavadocHover.getHoverInfo(elements, cu, new Region(range.getOffset(), range.getLength()), null);
String actualHtmlContent= hoverInfo.getHtml();
System.out.println(actualHtmlContent);

String expectedCodeSequence = "char <a class='header' href='eclipse-javadoc:%E2%98%82=TestSetupProject/src%3Cp'>p</a>.<a class='header' href='eclipse-javadoc:%E2%98%82=TestSetupProject/src%3Cp%7BJavadoc.java%E2%98%83Javadoc'>Javadoc</a>.c</span> : <span style='white-space:pre'>'' [\\u0000]";

int index= actualHtmlContent.lastIndexOf("char");
assertNotEquals(-1, index);
String actualSnippet= actualHtmlContent.substring(index, index + expectedCodeSequence.length());
assertEquals("sequence doesn't match", expectedCodeSequence, actualSnippet);
}
}

}

4 changes: 2 additions & 2 deletions org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,9 +1362,9 @@ private static StringBuffer addLink(StringBuffer buf, String uri, String label)

public static String getHexConstantValue(Object constantValue) {
if (constantValue instanceof Character) {
String constantResult= '\'' + constantValue.toString() + '\'';

char charValue= ((Character) constantValue);
String constantResult= '\'' + (charValue == 0 ? "" : constantValue.toString()) + '\''; //$NON-NLS-1$

String hexString= Integer.toHexString(charValue);
StringBuilder hexResult= new StringBuilder("\\u"); //$NON-NLS-1$
for (int i= hexString.length(); i < 4; i++) {
Expand Down
Loading