Handle Java 26 in standard places

[SougandhS]

Fixes : #832

What it does

How to test

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[SougandhS]

Hi @stephan-herrmann, could you please check this PR when you get a moment ?
org.eclipse.jdt.debug.tests.core.StratumTests.testAvailableStrata keeps failing, is there anything I missed ?

[SougandhS]

@stephan-herrmann some of the changes were already done via #766

[SougandhS]

Hi @stephan-herrmann, could you please check this PR when you get a moment ? org.eclipse.jdt.debug.tests.core.StratumTests.testAvailableStrata keeps failing, is there anything I missed ?

This was not failing on Mac local

[stephan-herrmann]

Regarding ModuleOptionsTests.testLimitModules_release9:

It looks like module jdk.jsobject, which was present in Java 9, has been removed in 26, and hence even --release 9 will not show it on JDK 26. Which would imply that we need a variant of ASSUMED_DEFAULT_MODULES_9 for platform 26 (sigh).

[stephan-herrmann]

Hi @stephan-herrmann, could you please check this PR when you get a moment ? org.eclipse.jdt.debug.tests.core.StratumTests.testAvailableStrata keeps failing, is there anything I missed ?

This was not failing on Mac local

This passes also for me (on linux).

[stephan-herrmann]

Some thoughts regarding StratumTest:

• previously, this test revealed issues with javaagent-shaded.jar, but I believe at those times a stratum was missing, whereas currently jenkins reports one more than expected. For previous discussions see, e.g.:
  • [24] Monitor failures in tests of Y-Builds #553 (comment)
  • [24] Monitor failures in tests of Y-Builds #553 (comment)
• an unexpected stratum could mean that jenkins runs tests with more plugins than we have locally, so another plugin might perform additional bytecode updates?
  • to gain a first hint I suggest we let the test print the names of all strata found, before any asserts.

[SougandhS]

It looks like module jdk.jsobject, which was present in Java 9, has been removed in 26, and hence even --release 9 will not show it on JDK 26. Which would imply that we need a variant of ASSUMED_DEFAULT_MODULES_9 for platform 26 (sigh).

Thanks, it is handled now

[SougandhS]

• to gain a first hint I suggest we let the test print the names of all strata found, before any asserts.

java & jdt - These are the 2 stratas

[stephan-herrmann]

java & jdt - These are the 2 stratas

We should actually be expecting these two.
Apparently, JavaCore.isSupportedJavaVersion() is driving us into the wrong branch, as if 26 was not supported in the BETA branch. This would imply that the build pulls jdt.core from the wrong branch.

For previous change in a BETA branch see d193199#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 but note that https://download.eclipse.org/eclipse/updates/4.39-Y-builds should be preferred over the generic Y-build URL.

[SougandhS]

For previous change in a BETA branch see d193199#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 but note that https://download.eclipse.org/eclipse/updates/4.39-Y-builds should be preferred over the generic Y-build URL.

Thanks, I have specified 4.39-Y in pom and now the test has passed

[SougandhS]

Will squash and merge soon 👍

[stephan-herrmann]

lgtm

[SougandhS]

Thanks again @stephan-herrmann