[118] Rename registryFile.jai to registryFile.imagen

[skalesse]

The PR closes #118 by:

1. remove ServiceLoader definitions from crop/jiffle/vectorize to prevent failing registry initialization
2. rename all registryFile.jai to registryFile.imagen to make a clearer distinction between JAI and ImageN registry handling

Summary:

• ImageN Ticket --> ImageN PR
• GeoTools Ticket --> GeoTools PR
• GeoServer Ticket --> GeoServer PR

[leonardehrenfried]

This is related: #120

You might have to update the geotools shade packaging instructions here https://docs.geotools.org/latest/userguide/build/faq.html#how-do-i-create-an-executable-jar-for-my-geotools-app both before and after this change.

[jodygarnett]

Wow @skalesse thanks for working so hard on this, and thinking it through and finding a lot of the downstream integration challenges. It is "exciting" working with pre 1.x releases 😆

I am just kicking off the builds, I expect the integration changes to fail so we may have to coordinate some PRs downstream to upgrade to 0.9.1-SNAPSHOT

[jodygarnett]

Looks like one failure:

Error: Exception in thread "main" java.nio.file.NoSuchFileException: ../modules/core/src/main/resources/META-INF/org.eclipse.imagen.registryFile.jai

I have a QA script to check if the registryFile contains what we expect; after too many mistakes moving operators between modules.

Please update https://github.com/eclipse-imagen/imagen/blob/main/bin/RegistryFileCheck.java as part of this PR and we should pass QA?

[skalesse]

@jodygarnett ,

you are right, for some reason I have missed that Q&A file. By checking again, I found a few more files I missed - I think I had concentrated on the modules and unsupported folders in my earlier commit.

I have now included all of ImageN. I think I have now found all places. Please see if that fixes your Q&A.

Thanks!

[skalesse]

Yet another commit - Sorry for that, but I just figured out that documentation is included in the repro. So I have updated the documentation for mentioning the name change from registryFile.jai to registryFile.imagen.

[skalesse]

This is related: #120

You might have to update the geotools shade packaging instructions here https://docs.geotools.org/latest/userguide/build/faq.html#how-do-i-create-an-executable-jar-for-my-geotools-app both before and after this change.

@leonardehrenfried good find. I will include this in the geotools docs for the PR#5414 for GeoTools that has the custom GeoTools registry files renamed to ImageN.

[skalesse]

Hi @jodygarnett ,

I wanted to ask what the status is of this request. I have committed a fix for your Q&A class and a few more occurrences of the registry file that needed to be fixed. If you like, you can restart the pipelines and we can see if they would now run successfully.

Thanks!
Sören

[jodygarnett]

Lovely! I am just at the foss4g event and intend to see these merges during the week and release during the community day.

[jodygarnett]

It is now the community day of foss4g and I have space to look at this, I will review and chase these changes through so GeoTools 34.1 can be released next week.

Thanks again for your dedication on this one!

[jodygarnett]

I have tested this change 0.9.1-SNAPSHOT using local builds:

• ImageIO-EXT
• GeoTools, using [GEOT-7832] Update ImageN to 0.9.1 (including rename of registry files) geotools/geotools#5414
• GeoWebCache, gathered 0.9.1-SNAPSHOT from geotools bom
• GeoServer, [GEOS-11987] ImageN 0.9.1 update requires renaming of registryFile.jai to registryFile.imagen geoserver/geoserver#8935

With that in mind I am going to start merging

[jodygarnett]

Manually merged, updating some of the commit descriptions