-
Notifications
You must be signed in to change notification settings - Fork 22
JAI to ImageN Rename of classes and constants #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Okay initial refactor of JAI class to ImageN class is landing, going to hold with the docs and migration and integration script until that works.
|
639366f to
00ef2f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
aaime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What an epic PR LOL and whoops!, I thoght I submitted this review but never pressed the "submit review" button. Sorry, here it is
I have found a few thing noted below. Besides that, grepping the supported part for JAI offers a number of other possibilties:
> git grep -i JAI -- "**/*.java" | grep -v legacy | grep -v unsupported | wc -l
1774
Out of that large selection, here is a few notes.
- There is still a fair amount of JaiI18n classes around, mostly because they are specific to a module. From the root of the checkout:
> find . -name JaiI18N.java | wc -l
33
- There is still a few notable classes that contain JAI in their name. Excluding the legacy and demo modules, we have:
./modules/colorconvert/src/main/java/org/eclipse/imagen/media/colorconvert/ColorSpaceJAIExtWrapper.java
./modules/colorconvert/src/main/java/org/eclipse/imagen/media/colorconvert/IHSColorSpaceJAIExt.java
./modules/colorconvert/src/main/java/org/eclipse/imagen/media/colorconvert/ColorSpaceJAIExt.java
./modules/core/src/main/java/org/eclipse/imagen/PropertyChangeEventJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ColorSpaceJAI.java
./modules/core/src/main/java/org/eclipse/imagen/LookupTableJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ParameterBlockJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ComponentSampleModelJAI.java
./modules/core/src/main/java/org/eclipse/imagen/PropertyChangeSupportJAI.java
./modules/core/src/main/java/org/eclipse/imagen/KernelJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ImageJAI.java
./modules/imagefunction/src/main/java/org/eclipse/imagen/media/imagefunction/ImageFunctionJAIEXT.java
./modules/imagefunction/src/main/java/org/eclipse/imagen/media/imagefunction/ImageFunctionJAIEXTWrapper.java
-
Docs are still referring to JAI.create
-
There are places where we see jai still used as a variable, e.g.:
ImageN jai = ImageN.getDefaultInstance();
modules/affine/src/test/java/org/eclipse/imagen/media/affine/ComparisonTest.java
Show resolved
Hide resolved
Refactor JAI resource strings
bc0cd81 to
0b98d79
Compare
Wow - thanks for the epic review! Working on it... |
This also includes subclasse ColorSpaceImageNExt, ColoSpaceImageNextWrapper, and IHSColorSpaceImageNExt
Also sub-types ImageFunctionJAIEXTWrapper to ImageFunctionExtWrapper
55d83c3 to
f5e6454
Compare
Refactor references to JAI in classes and constants:
pom2andupdate2targetsReference:
Concurrent merge of jai-rename branches:
Reviewers: Note complete ImageN integration test, or check out everything and build locally.