Skip to content

Conversation

@jodygarnett
Copy link
Contributor

@jodygarnett jodygarnett commented Sep 25, 2025

Refactor references to JAI in classes and constants:

  • integration.yml modified run pom2 and update2 targets
  • Rename internal JaiI18N classes to ImageN18N and ImageNLegacy18N
  • Rename public JAI class to ImageN, provide a legacy JAI class placeholder
  • Rename parameter blocks that start with JAI
  • Rename constants that start with JAI
  • Rename ColorSpaceJAIExtWrapper
  • Rename IHSColorSpaceJAIExt
  • Rename ColorSpaceJAIExt
  • Rename PropertyChangeEventJAI
  • Rename ColorSpaceJAI
  • Rename LookupTableJAI
  • Rename ParameterBlockJAI --> ParameterBlockImageN
  • Rename ComponentSampleModelJAI
  • Rename PropertyChangeSupportJAI
  • Rename KernelJAI
  • Rename ImageJAI
  • Rename ImageFunctionJAIEXT
  • Rename ImageFunctionJAIEXTWrapper
  • Deprecated subclass ColorSpaceJAIExtWrapper
  • Deprecated subclass IHSColorSpaceJAIExt
  • Deprecated subclass ComponentSampleModelJAI

Reference:

Concurrent merge of jai-rename branches:

Reviewers: Note complete ImageN integration test, or check out everything and build locally.

@jodygarnett jodygarnett linked an issue Sep 25, 2025 that may be closed by this pull request
@jodygarnett jodygarnett added this to the 0.9.0 milestone Sep 25, 2025
@jodygarnett jodygarnett moved this to In progress in ImageN Development Sep 25, 2025
@jodygarnett jodygarnett changed the title Reference to JAI in API and javadocs JAI to ImageN Rename of classes and constants Sep 25, 2025
@jodygarnett
Copy link
Contributor Author

jodygarnett commented Sep 25, 2025

Okay initial refactor of JAI class to ImageN class is landing, going to hold with the docs and migration and integration script until that works.

  • All jai-rename branches in downstream projects are created
  • Migration script has pom2 and update2 targets for independent 0.4.0 - 0.9 change
  • Refactor also updated the documentation markdown files so that needs to be checked

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an epic PR LOL and whoops!, I thoght I submitted this review but never pressed the "submit review" button. Sorry, here it is

I have found a few thing noted below. Besides that, grepping the supported part for JAI offers a number of other possibilties:

> git grep -i JAI -- "**/*.java" | grep -v legacy | grep -v unsupported | wc -l
1774

Out of that large selection, here is a few notes.

  1. There is still a fair amount of JaiI18n classes around, mostly because they are specific to a module. From the root of the checkout:
> find . -name JaiI18N.java | wc -l
33
  1. There is still a few notable classes that contain JAI in their name. Excluding the legacy and demo modules, we have:
./modules/colorconvert/src/main/java/org/eclipse/imagen/media/colorconvert/ColorSpaceJAIExtWrapper.java
./modules/colorconvert/src/main/java/org/eclipse/imagen/media/colorconvert/IHSColorSpaceJAIExt.java
./modules/colorconvert/src/main/java/org/eclipse/imagen/media/colorconvert/ColorSpaceJAIExt.java
./modules/core/src/main/java/org/eclipse/imagen/PropertyChangeEventJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ColorSpaceJAI.java
./modules/core/src/main/java/org/eclipse/imagen/LookupTableJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ParameterBlockJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ComponentSampleModelJAI.java
./modules/core/src/main/java/org/eclipse/imagen/PropertyChangeSupportJAI.java
./modules/core/src/main/java/org/eclipse/imagen/KernelJAI.java
./modules/core/src/main/java/org/eclipse/imagen/ImageJAI.java
./modules/imagefunction/src/main/java/org/eclipse/imagen/media/imagefunction/ImageFunctionJAIEXT.java
./modules/imagefunction/src/main/java/org/eclipse/imagen/media/imagefunction/ImageFunctionJAIEXTWrapper.java
  1. Docs are still referring to JAI.create

  2. There are places where we see jai still used as a variable, e.g.:

ImageN jai = ImageN.getDefaultInstance();

@jodygarnett
Copy link
Contributor Author

What an epic PR LOL and whoops!, I thoght I submitted this review but never pressed the "submit review" button. Sorry, here it is

Wow - thanks for the epic review! Working on it...

@jodygarnett jodygarnett merged commit d1f5339 into main Oct 5, 2025
8 checks passed
jodygarnett added a commit to mapfish/mapfish-print-v2 that referenced this pull request Oct 5, 2025
@jodygarnett jodygarnett deleted the jai-rename branch October 5, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference to JAI in API and javadocs

3 participants