refactor: apply editorial changes #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliapampus
force-pushed
the
refactor/editorial-changes
branch
from
8d9b48f to
4690a70
Compare
juliapampus
force-pushed
the
refactor/editorial-changes
branch
from
4690a70 to
f07aa55
Compare
juliapampus
changed the title
juliapampus
force-pushed
the
refactor/editorial-changes
branch
from
f07aa55 to
7d5bf64
Compare
Merged
arnoweiss
reviewed
Jun 27, 2025
arnoweiss
suggested changes
Jun 27, 2025
Contributor
arnoweiss
left a comment
arnoweiss
left a comment
There was a problem hiding this comment.
There's some change in normativity implied in these changes.
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
specifications/negotiation/contract.negotiation.binding.https.md
Outdated
Show resolved
Hide resolved
juliapampus
force-pushed
the
refactor/editorial-changes
branch
from
4ed72e4 to
3bbe01c
Compare
juliapampus
force-pushed
the
refactor/editorial-changes
branch
from
3bbe01c to
b35081b
Compare
arnoweiss
approved these changes
Jun 27, 2025
Contributor
arnoweiss
left a comment
arnoweiss
left a comment
There was a problem hiding this comment.
Thanks for incorporating the feedback
jimmarino
approved these changes
Jun 27, 2025
juliapampus
merged commit f441cc3
into
eclipse-dataspace-protocol-base:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds editorial changes:
Why it does that
Consistency in writing
Linked Issue(s)
Closes #13
Closes #114
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.