fix: remove callbackAddress from ContractOfferMessage #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Jun 15, 2025
arnoweiss
approved these changes
Jun 16, 2025
Contributor
There was a problem hiding this comment.
Ok, we likely shoudn't have these in here.
Contributor
Author
|
Will be covered by #155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Removes
callbackAddressfromContractOfferMessage.Why it does that
The provider does not add a
callbackAddressproperty to messages.Further notes
--
Linked Issue(s)
Relates #154
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.