chore: explain endpointType #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Jun 12, 2025
Contributor
jimmarino
left a comment
jimmarino
left a comment
There was a problem hiding this comment.
A suggested to make the profile definition a little bit more concise.
Co-authored-by: Jim Marino <[email protected]>
juliapampus
approved these changes
Jun 15, 2025
juliapampus
merged commit 9da6ca6
into
eclipse-dataspace-protocol-base:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds explanations on the semantics of
endpointTypeand its relationship to theendpointProperties. Formally Introduces the profile term.Why it does that
Give context on what this mandtory property (that's basically just a string right now) should be used for.
Linked Issue(s)
Closes #51
Closes #183