Skip to content

Add copyright checker#17

Merged
MarkMelotto merged 17 commits intomainfrom
add-copyright-check
Apr 24, 2025
Merged

Add copyright checker#17
MarkMelotto merged 17 commits intomainfrom
add-copyright-check

Conversation

@BSchilperoort
Copy link
Member

@BSchilperoort BSchilperoort commented Apr 15, 2025

@BSchilperoort
Copy link
Member Author

@RolfHut @MarkMelotto this PR adds the copyright checker. In its current behavior it expects a yml file with every image.

Obviously this fails now.

I have set up branch protection rules for main now. This should prevent any direct pushes to main, or merges from PRs that don't have approval from a reviewer. You could consider also selecting the rule "Require status checks to pass" to enforce this checker.

@BSchilperoort BSchilperoort marked this pull request as ready for review April 15, 2025 09:01
@MarkMelotto
Copy link
Contributor

@BSchilperoort I am adding 2 thesis projects first and the tutorial stuff. Then I can take a look at the checker and add the correct files, hopefully tomorrow afternoon

@RolfHut
Copy link
Contributor

RolfHut commented Apr 16, 2025

I will not have time to look at this in detail till after the easter weekend, sorry

* first fix for tutorials, cleaning up the HBV code

* more fixes and linter stuff

* added both pdf thesises

* samenvatting toegevoegd

* added Gelt thesis

* added Gelt links and the updated ToC

* updated eline up until methodology

* added server launch button to projects for EGU

* added the tutorial to the intro.md

* added tutorial to the readme

* fixed figure

* added correct folder

* small change

* small changes, fixed 1 tutorial, should work now out of the box

* fixed pcrglob, but plots are still bad

* added full date for now and changed the printing to a statusbar

* cleaned up the pathing, which is probably still bad and not working, so let me check that tomorrow.
+ added hbv modelled discharge
+ added correct units to pcr

* update to tutorials md for EGU

* updated PCRglob notebook to work for EGU

* updated Elines thesis

* updated the figures of Ischa

* fix to ToC

* small changes and fixes for bigger more complicated tables

* table test

* table test

* table test 3

* table test 4

* table test 5

* table test 6

* table test 7

* table test 8

* table test 9

* table test 10 final

* final updates on BSc thesis projects for a while

* quick build fix

* added in the comments of Rolf

* added in the comments of Rolf, now also to PCR

* using correct forcing path now

* ran the notebooks

* updated changelog

* - updated changelog
- removed redundant files of Thirza
- Added Zoe

* reverted back to comments instead of docstring

* Fixed an error

Fixed an error when setting the PCR data points

* fixed jupyterhub launch image

* small fix to Gelt

* Gelt title is now in english
added Zoë to the list

---------

Co-authored-by: Mark Melotto <[email protected]>
Co-authored-by: Rolf Hut <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MarkMelotto
Copy link
Contributor

@BSchilperoort maybe it is nice to put the yml files in a separate folder as apposed to how it is now?
Suggestion:
-content/image.png
-content/copyright/image.png.yml

@MarkMelotto MarkMelotto merged commit e2ee7b7 into main Apr 24, 2025
7 checks passed
@MarkMelotto MarkMelotto deleted the add-copyright-check branch April 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants