create examples Kotlin Data classes features#48
Merged
Conversation
e5LA
reviewed
Aug 15, 2025
e5LA
reviewed
Aug 15, 2025
e5LA
reviewed
Aug 15, 2025
e5LA
reviewed
Aug 15, 2025
e5LA
reviewed
Aug 15, 2025
e5LA
reviewed
Aug 15, 2025
Owner
|
Thanks for another contribution, @KonstantinKhan! I like how this covers both the core features and the common pitfalls of data classes. Just a few small tweaks suggested, but overall, great work! It’s our first Kotlin feature showcase, so we could also think about organizing the example to make it a bit easier to follow. For instance: What do you think? |
6ce5972 to
287ebdf
Compare
Contributor
Author
|
I think that it's a good idea. |
e5LA
approved these changes
Aug 23, 2025
Owner
e5LA
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback and making those improvements - the code is now even cleaner and more educational :)
Great contribution to the collection! 🎉 thanks @KonstantinKhan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kotlin Data classes features
Related Issue
Closes #41