Merged
Conversation
This makes documented replacements have an optional URL rather than it being required. Most or all documented replacements are part of a mapping which itself has the unified documentation (of all replacements for that mapping). So we don't really need to repeat the same URL per replacement.
Contributor
Author
|
@ghostdevv @gameroman thoughts on this? |
ghostdevv
approved these changes
Apr 13, 2026
Collaborator
ghostdevv
left a comment
ghostdevv
left a comment
There was a problem hiding this comment.
Sounds good - we should really make some linting rules for the replacements, one of which could make sure that either the replacement or mapping has docs when relevant
Contributor
Author
this is a good idea 👍 we do already have some rules, and roman added a few recently. so would be good to add this one too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A
📚 Description
This makes documented replacements have an optional URL rather than it
being required. Most or all documented replacements are part of a
mapping which itself has the unified documentation (of all replacements
for that mapping). So we don't really need to repeat the same URL per
replacement.