fix: capture bound function result in instrumentDO #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bind() method returns a new bound function but the code was discarding the return value. This caused 'Illegal invocation' errors when calling Durable Object methods via RPC. Fixes method binding for Cloudflare Workers RPC calls and PartyServer .name property access.
Author
|
lol oops wrong repo. but feel free to accept if you like the patch |
grrowl
force-pushed
the
fix-do-binding
branch
2 times, most recently
from
042bfec to
e2c9a03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bind() method returns a new bound function but the code was discarding the return value. This caused 'Illegal invocation' errors when calling Durable Object methods via RPC.
Fixes method binding for Cloudflare Workers RPC calls and this.name property access.