update: fixing java18 module error #2
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical structural error in the Java 18 module's Main.java file where the class structure was inverted (lines were in reverse order, making the code syntactically invalid). The fix reorders the code to match the correct Java class structure pattern used consistently across other Java version modules in the repository.
Key Changes
- Corrected the line order of Main.java from an inverted/reversed state to proper Java syntax
- The fixed structure now matches the pattern used in java19, java20, and other module Main classes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| <profile> | ||
| <id>build-java8</id> | ||
| <activation/> | ||
| <properties> | ||
| <!-- Override Spring Boot parent's maven.compiler.release property --> | ||
| <!-- Java 8 does not support the release flag, so we unset it and use source/target --> | ||
| <maven.compiler.release></maven.compiler.release> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| </properties> | ||
| <modules> | ||
| <module>java8</module> | ||
| </modules> | ||
| </profile> |
There was a problem hiding this comment.
Inconsistent indentation: This <profile> tag uses tabs instead of the mixed tabs/spaces pattern used in the rest of the profiles section. Line 122 shows the expected indentation with tabs followed by <profile>. This line should match that pattern for consistency.
| <profile> | |
| <id>build-java8</id> | |
| <activation/> | |
| <properties> | |
| <!-- Override Spring Boot parent's maven.compiler.release property --> | |
| <!-- Java 8 does not support the release flag, so we unset it and use source/target --> | |
| <maven.compiler.release></maven.compiler.release> | |
| <maven.compiler.source>1.8</maven.compiler.source> | |
| <maven.compiler.target>1.8</maven.compiler.target> | |
| </properties> | |
| <modules> | |
| <module>java8</module> | |
| </modules> | |
| </profile> | |
| <profile> | |
| <id>build-java8</id> | |
| <activation/> | |
| <properties> | |
| <!-- Override Spring Boot parent's maven.compiler.release property --> | |
| <!-- Java 8 does not support the release flag, so we unset it and use source/target --> | |
| <maven.compiler.release></maven.compiler.release> | |
| <maven.compiler.source>1.8</maven.compiler.source> | |
| <maven.compiler.target>1.8</maven.compiler.target> | |
| </properties> | |
| <modules> | |
| <module>java8</module> | |
| </modules> | |
| </profile> |
|
|
||
| These are just warnings when building with a newer JDK (e.g., Java 25) targeting an older version (Java 8). The code compiles correctly and runs fine. | ||
|
|
||
| **Status:** ✅ RESOLVED (Fixed in java8 module - Nov 30, 2025) |
There was a problem hiding this comment.
The date 'Nov 30, 2025' appears to be a typo. Based on the context (documentation last updated November 30, 2025 on line 5), this should likely say 'Nov 30, 2024' or be consistent with the last updated date. Please verify the correct date.
No description provided.