Add alpha support for ML-DSA using Dilithium-py #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for use of public keys using ML-DSA 44, ML-DSA 65, and ML-DSA 87 PQC algorithms. This particular implementation uses the
dilithium-pylibrary when present. A newwebauthn.helpers.exceptions.MLDSANotSupportedexception will be raised if a response using these algorithms is passed in withoutdilithium-pyinstalled.Dilithium-py was chosen to facilitate a more timely collaboration. I tried to abstract its use enough to make it easier, in the future, to replace most of this with whatever PQC support ends up getting added to cryptography. This appears to be the parent task over there to track progress on adding ML-DSA support:
pyca/cryptography#12610
Unit tests exist locally that pass with this logic. The WebAuthn responses used for those tests cannot be included in this PR. The plan is to publish this change as an alpha build of v2.8.0, update webauthn.io to use it, then capture some new responses on webauthn.io that can then be backfilled here to properly incorporate testing around this PQC support.
Supersedes #258.