SERP Settings Sync: Return noNativeSettings on first launch #7385
+33
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1212402385991388?focus=true
Description
When SERP Settings Sync is enabled and a user launches the app for the first time (or migrates), the getNativeSettings handler now returns
{ noNativeSettings: true }instead of an empty JSON object. This signals to the SERP that this is a first launch/migration scenario, allowing the SERP to handle the initial state appropriately.This is returned until the FE calls the updateNativeSettings and updates the locally stored serp settings.
Steps to test this PR
See testing steps
UI changes
N/A
Note
getNativeSettingsnow returns{ noNativeSettings: true }until settings are stored, otherwise returns the stored JSON.GetNativeSettingsHandlerto return{ "noNativeSettings": true }when no settings are stored; otherwise parse and return stored JSON.KEY_NO_NATIVE_SETTINGSconstant.noNativeSettings: truefor null settings and treat"{}"as an empty object.idis null, response when present).Written by Cursor Bugbot for commit b829717. This will update automatically on new commits. Configure here.