Skip to content

Conversation

@mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Dec 17, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1212402385991388?focus=true

Description

When SERP Settings Sync is enabled and a user launches the app for the first time (or migrates), the getNativeSettings handler now returns { noNativeSettings: true } instead of an empty JSON object. This signals to the SERP that this is a first launch/migration scenario, allowing the SERP to handle the initial state appropriately.

This is returned until the FE calls the updateNativeSettings and updates the locally stored serp settings.

Steps to test this PR

See testing steps

UI changes

N/A


Note

getNativeSettings now returns { noNativeSettings: true } until settings are stored, otherwise returns the stored JSON.

  • SERP Settings Sync
    • Update GetNativeSettingsHandler to return { "noNativeSettings": true } when no settings are stored; otherwise parse and return stored JSON.
    • Add KEY_NO_NATIVE_SETTINGS constant.
  • Tests
    • Adjust expectations to noNativeSettings: true for null settings and treat "{}" as an empty object.
    • Add test verifying the flag is returned until settings are persisted, then actual values are returned.
    • Keep id-handling behavior (no response when id is null, response when present).

Written by Cursor Bugbot for commit b829717. This will update automatically on new commits. Configure here.

@mikescamell mikescamell force-pushed the feature/mike/serp-settings-sync/return-nonativesettings-on-first-launch branch 3 times, most recently from ed04fa1 to 9f50fe4 Compare December 18, 2025 15:49
@mikescamell mikescamell marked this pull request as ready for review December 18, 2025 15:56
@mikescamell mikescamell force-pushed the feature/mike/serp-settings-sync/return-nonativesettings-on-first-launch branch from 9f50fe4 to 4eb7b40 Compare December 18, 2025 16:13
… settings

We need a way to signal to the FE that SERP settings have not been migrated yet. We return until the FE has made a call to UpdateNativeSettingsHandler.kt that signals we should now store the settings in the browser. From then on we'll return the stored settings.
@mikescamell mikescamell force-pushed the feature/mike/serp-settings-sync/return-nonativesettings-on-first-launch branch from 4eb7b40 to b829717 Compare December 18, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant