Return number of inserted rows when calling flush()#359
Merged
staticlibs merged 1 commit intoduckdb:mainfrom Sep 8, 2025
Merged
Return number of inserted rows when calling flush()#359staticlibs merged 1 commit intoduckdb:mainfrom
flush()#359staticlibs merged 1 commit intoduckdb:mainfrom
Conversation
Collaborator
|
Thanks for the PR! It looks good to me, I've added a very minor fix on top of it and merged it in #364. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This enables the verification that the appender flushed the expected number of records, preventing silent data loss. By returning the count of flushed rows, the caller can assert that
flush()processed exactly the number of rows they intended to write, catching potential issues in data pipelines early.