Fix incorrect character encoding in GetLastErrorAsString on Windows#323
Closed
soutong wants to merge 2 commits intoduckdb:mainfrom
Closed
Fix incorrect character encoding in GetLastErrorAsString on Windows#323soutong wants to merge 2 commits intoduckdb:mainfrom
soutong wants to merge 2 commits intoduckdb:mainfrom
Conversation
Collaborator
|
Hi, thanks for the fix! It looks good to me. Just to be integrated it needs to be submitted to the https://github.com/duckdb/duckdb repo. |
Author
|
Hi, thanks for the heads-up! I've already opened a PR to duckdb:main — feel free to take a look whenever you get a chance. Appreciate your help! duckdb/duckdb#18431 |
Collaborator
|
Thanks for moving it to the main repo! I've commented there and added one minor suggestion. I'll close this PR in favour of the duckdb/duckdb#18431 one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a character encoding issue on Windows where error messages retrieved using
GetLastError()andFormatMessageAmay be garbled when non-ASCII characters are involved.Changes
FormatMessageAwithFormatMessageWto retrieve wide-character error messages.std::wstringto UTF-8 usingWindowsUtil::UnicodeToUTF8.Why
On localized Windows systems,
FormatMessageAcan return garbled messages when using non-ASCII locale (e.g., Chinese). This patch ensures proper Unicode support.