Skip to content

Support memory DBs in URL without leading c. (1.3) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staticlibs merged 1 commit into from
Jun 15, 2025
Merged

Support memory DBs in URL without leading c. (1.3) #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/duckdb/DuckDBConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ public static DuckDBConnection newConnection(String url, boolean readOnly, Prope
if (db_dir.length() == 0) {
db_dir = ":memory:";
}
if (db_dir.startsWith("memory:")) {
db_dir = ":" + db_dir;
}
ByteBuffer nativeReference = DuckDBNative.duckdb_jdbc_startup(db_dir.getBytes(UTF_8), readOnly, properties);
return new DuckDBConnection(nativeReference, url, readOnly);
}
Expand Down
20 changes: 20 additions & 0 deletions src/test/java/org/duckdb/TestDuckDBJDBC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3484,6 +3484,26 @@ public QueryProgress call() throws Exception {
}
}

public static void test_memory_colon() throws Exception {
try (Connection conn1 = DriverManager.getConnection("jdbc:duckdb::memory:");
Statement stmt1 = conn1.createStatement();
Connection conn2 = DriverManager.getConnection("jdbc:duckdb:memory:");
Statement stmt2 = conn2.createStatement(); Statement stmt22 = conn2.createStatement()) {
stmt1.execute("CREATE TABLE tab1(col1 int)");
assertThrows(() -> { stmt2.execute("DROP TABLE tab1"); }, SQLException.class);
stmt22.execute("CREATE TABLE tab1(col1 int)");
}
try (Connection conn1 = DriverManager.getConnection("jdbc:duckdb::memory:tag1");
Statement stmt1 = conn1.createStatement(); Statement stmt12 = conn1.createStatement();
Connection conn2 = DriverManager.getConnection("jdbc:duckdb:memory:tag1");
Statement stmt2 = conn2.createStatement()) {
stmt1.execute("CREATE TABLE tab1(col1 int)");
stmt2.execute("DROP TABLE tab1");
assertThrows(() -> { stmt1.execute("DROP TABLE tab1"); }, SQLException.class);
stmt12.execute("CREATE TABLE tab1(col1 int)");
}
}

public static void main(String[] args) throws Exception {
String arg1 = args.length > 0 ? args[0] : "";
final int statusCode;
Expand Down