Support disabling auto-commit mode in properties#236
Merged
staticlibs merged 1 commit intoduckdb:mainfrom May 30, 2025
Merged
Conversation
JDBC spec requires the driver to have `autoCommit` enabled on newly created connections. Changing `autoCommit` using `conn#setAutoCommit()` may be not convenient in some environments with limited access to Java API (e.g. Spark SQL). This change adds a new `jdbc_auto_commit` connection property that allows to create connections with `autoCommit` disabled. Testing: new test added to check that property is effective and that the default mode is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDBC spec requires the driver to have
autoCommitenabled on newly created connections. ChangingautoCommitusingconn#setAutoCommit()may be not convenient in some environments with limited access to Java API (e.g. Spark SQL).This change adds a new
jdbc_auto_commitconnection property that allows to create connections withautoCommitdisabled.Testing: new test added to check that property is effective and that the default mode is unchanged.